Fixing bug when opening corrupted archive works for the second time
ClosedPublic

Authored by martinkostolny on Aug 23 2016, 7:06 PM.

Details

Summary

Toni discovered a bug where you can open a corrupted archive after opening a valid one. Steps to reproduce:

  1. Use right arrow key to enter a valid e.g. valid.7z archive
  2. Go back (left arrow key)
  3. Create an empty file named "wrong.7z"
  4. Use right arrow key to enter this invalid archive -> it fails
  5. Do it again -> it succeeds and you are now browsing previous valid archive with "krarc://.../wrong.7z/..." in address bar

This patch should fix it.

Test Plan
  • use steps above
  • enter valid archive, read files in it, write to it

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
martinkostolny retitled this revision from to Fixing bug when opening corrupted archive works for the second time.
martinkostolny updated this object.
martinkostolny edited the test plan for this revision. (Show Details)
martinkostolny added a reviewer: Krusader.
martinkostolny set the repository for this revision to R167 Krusader.
martinkostolny added a project: Krusader.
gengisdave accepted this revision.Aug 23 2016, 7:29 PM
gengisdave added a reviewer: gengisdave.
This revision is now accepted and ready to land.Aug 23 2016, 7:29 PM
asensi accepted this revision.Aug 23 2016, 8:50 PM
asensi added a reviewer: asensi.
asensi added a subscriber: asensi.

Every test went well there :-) That's great! Thanks, Martin!

This revision was automatically updated to reflect the committed changes.