Differential D25509

[applets/Weather] Port config UI mostly to QQC2 and away from Plasma components
ClosedPublic
Actions

Authored by ngraham on Nov 24 2019, 5:25 PM.

Details

Reviewers
spstarr
Group Reviewers
Plasma
Commits
R114:c96809b1dac2: [applets/Weather] Port config UI mostly to QQC2 and away from Plasma components
Summary

Everything is ported to QQC2 except for the TableView since there is no direct analogue
in QQC2. The correct porting path is a ScrollView+ListView, but I can't do this right
now since the search/weather station selection functionality is currently broken for me,
making it impossible to test changes to the table.

Test Plan

Everything that was working before still works now

Diff Detail

Repository
R114 Plasma Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Nov 24 2019, 5:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 24 2019, 5:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Nov 24 2019, 5:25 PM
spstarr added a comment.Nov 26 2019, 11:43 PM

For the applet side, I didn't rewrite this, the original applet was non-QtQuick even, but even so, this looks sane to me.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2019, 12:16 AM
Closed by commit R114:c96809b1dac2: [applets/Weather] Port config UI mostly to QQC2 and away from Plasma components (authored by ngraham). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 70385

View Options

applets/weather/package/contents/ui/config/ConfigWeatherStation.qml

Loading...
View Options

applets/weather/package/contents/ui/config/WeatherStationPicker.qml

Loading...
View Options

applets/weather/package/contents/ui/config/WeatherStationPickerDialog.qml

Loading...