Remove Attica from KAboutDialog
Needs ReviewPublic

Authored by broulik on Sun, Nov 24, 1:54 PM.


Group Reviewers

It's defunct and unused and would mean a surprise network request when opening the About dialog.
Gets rid of everything that cannot be done with just KAboutData, i.e. everything about avatar handling and painting, a person's "location",

Test Plan


  • About dialog in various apps still looks alright

Diff Detail

R263 KXmlGui
Lint Skipped
Unit Tests Skipped
broulik created this revision.Sun, Nov 24, 1:54 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, Nov 24, 1:54 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Sun, Nov 24, 1:54 PM
broulik retitled this revision from Remove Attica to Remove Attica from KAboutDialog.
broulik edited the summary of this revision. (Show Details)
leinir added a subscriber: leinir.Mon, Nov 25, 11:22 AM

Given the amount of work being put into the KDE Store recently, i am dismayed that it is considered undesirable that we should use the information the store provides us. I understand the surprise phone-home-ness it suggests, but i also am not at all happy with this. It is, however, not my decision, and while i know that we talked about this last autumn and you agreed to hold off on doing this patch, i guess others have weighed in during a sprint i didn't attend (which is my own fault). It seems to me, however, that the fix to this code not being used is to add the usernames of people to about dialogues, rather than removing the functionality.