Remove Attica from KAboutDialog
Needs ReviewPublic

Authored by broulik on Nov 24 2019, 1:54 PM.

Details

Reviewers
None
Group Reviewers
Frameworks
Summary

It's defunct and unused and would mean a surprise network request when opening the About dialog.
Gets rid of everything that cannot be done with just KAboutData, i.e. everything about avatar handling and painting, a person's "location",

Test Plan

T12198

  • About dialog in various apps still looks alright

Diff Detail

Repository
R263 KXmlGui
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Nov 24 2019, 1:54 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 24 2019, 1:54 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Nov 24 2019, 1:54 PM
broulik retitled this revision from Remove Attica to Remove Attica from KAboutDialog.
broulik edited the summary of this revision. (Show Details)
leinir added a subscriber: leinir.Nov 25 2019, 11:22 AM

Given the amount of work being put into the KDE Store recently, i am dismayed that it is considered undesirable that we should use the information the store provides us. I understand the surprise phone-home-ness it suggests, but i also am not at all happy with this. It is, however, not my decision, and while i know that we talked about this last autumn and you agreed to hold off on doing this patch, i guess others have weighed in during a sprint i didn't attend (which is my own fault). It seems to me, however, that the fix to this code not being used is to add the usernames of people to about dialogues, rather than removing the functionality.

Right, with the influx of blog entries, a chat with Kai Uwe and a bit of mental distance to it, it is a bit clearer precisely why this stuff is being attempted. So, i'm entirely in favour of narrowing the hard dependencies in Frameworks in general, and in that spirit, what would be nice to work out would be a way of achieving a similar result to this, without the hard dependency on Attica. So, for that purpose, one requirement for this to be changed would be to have https://phabricator.kde.org/T10138 get under way, and similarly rather than having the information directly in the UI the way the Attica support enables us to, simply having a link to the author's opendesktop profile would likely suffice. For example, mine is https://www.opendesktop.org/u/leinir/

Right! Only a mere tiny short while later, the store has as of now got support for that avatar thing based on just the username - in a neat variety of ways, as well :) See Alexander's comment here for details: https://phabricator.kde.org/T10138#254182 (and i'll need to do some not-some-random-comment documentation for that somewhere useful)

There we go - had to do some surgery to make it work, since of course kxmlgui has moved on since this patch was first made, but i've got an MR under way on https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/57 (currently WIP because i want to add in functionality to not force onlineness until people allow it) which implements the most important part of this diff, being the part about removing the hard(ish) dependency on Attica.