add a preview button and a fullscreen preview
ClosedPublic

Authored by mart on Aug 23 2016, 12:03 PM.

Details

Summary

preview button for themes, launches a fullscreen preview for the theme
the preview image is shown as big as possible, either 1:1 or
scaled down to screen size.

clicking anywhere (or in the top right close button) dismissed the
fullscreen dialog

the thumbnail uses a plasma toolbutton, but in that particular point is fine
to use a plasma control, because it's on top of an image, it's
a custom graphics zone, where on the other hand a system style
toolbutton wouldn't work well.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 6194.Aug 23 2016, 12:03 PM
mart retitled this revision from to add a preview button and a fullscreen preview.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptAug 23 2016, 12:03 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a project: VDG.

overlaying a theme with preview:
http://imgur.com/a/FVXDH

preview:
http://imgur.com/a/LhBjw

davidedmundson added inline comments.
kcms/lookandfeel/kcm.h
55

this seems like a different change

kcms/lookandfeel/package/contents/ui/main.qml
145

Why the Plasma one? Everything else is QQC in this file?

mart added inline comments.Aug 23 2016, 12:17 PM
kcms/lookandfeel/kcm.h
55

ah, right, i dropped the part about HasDefaultLayoutRole, will remove

kcms/lookandfeel/package/contents/ui/main.qml
145

as explained in the message, is purely an estetic thing, there the plasma one is fine as is on top of the thumbnail, that is an area where the qstyle control wouldn't visually work at all.
It's coherent with the ksplash kcm (i'm fine with an alternate design that works, but both should be updated)

mart updated this revision to Diff 6196.Aug 23 2016, 12:20 PM
  • remove hasdefaultlayoutrole
davidedmundson accepted this revision.Aug 23 2016, 12:30 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Aug 23 2016, 12:30 PM
This revision was automatically updated to reflect the committed changes.