Gets rid of some code duplication.
Details
Details
- Reviewers
ngraham - Group Reviewers
Plasma VDG - Commits
- R119:c743d36b0372: [Colors / Desktop Theme KCM] Use Kirigami.SearchField
- Filtering works
- Clear button works
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
The translation part of SearchField is indeed buggy: https://bugs.kde.org/show_bug.cgi?id=413900
May be it's not time to adopt it yet?
Comment Actions
IMO, more like time to fix that bug. :) In the worst-case scenario, you can override placeholderText here and provide a translated string.
However there is a deeper problem: now that System Settings uses a SearchField in its own toolbar, the Ctrl+F shortcut to trigger it becomes ambiguous. I guess we need to fix that too. However I see that this is already the case even without this patch, so there's no regression here at least.
Therefore, +1.
Comment Actions
Ah, right. Thanks for the reminder!
How about including the workaround in this patch?
Comment Actions
- Add i18n to work around translation loading bug
- Also port desktoptheme KCM which has a copy of this