[Colors KCM] Use Kirigami.SearchField
Changes PlannedPublic

Authored by broulik on Fri, Nov 22, 1:32 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Summary

Gets rid of some code duplication.

Test Plan
  • Filtering works
  • Clear button works

For some reason it's not translated

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Fri, Nov 22, 1:32 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Nov 22, 1:32 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Fri, Nov 22, 1:32 PM

The translation part of SearchField is indeed buggy: https://bugs.kde.org/show_bug.cgi?id=413900

May be it's not time to adopt it yet?

ngraham accepted this revision.Fri, Nov 22, 2:29 PM
ngraham added a subscriber: ngraham.

The translation part of SearchField is indeed buggy: https://bugs.kde.org/show_bug.cgi?id=413900

May be it's not time to adopt it yet?

IMO, more like time to fix that bug. :) In the worst-case scenario, you can override placeholderText here and provide a translated string.

However there is a deeper problem: now that System Settings uses a SearchField in its own toolbar, the Ctrl+F shortcut to trigger it becomes ambiguous. I guess we need to fix that too. However I see that this is already the case even without this patch, so there's no regression here at least.

Therefore, +1.

This revision is now accepted and ready to land.Fri, Nov 22, 2:29 PM

In the worst-case scenario, you can override placeholderText here and provide a translated string.

Ah, right. Thanks for the reminder!

How about including the workaround in this patch?

broulik planned changes to this revision.Thu, Dec 5, 9:10 PM

I'd prefer if the translation were fixed, but I can override placeholderText