Reset guiding calibration if the mount moves and "Always Reset Guide Calibration" option is set.

Authored by wreissenberger on Nov 21 2019, 10:34 PM.



Selecting the scheduler option "Always Reset Guide Calibration" means, that the calibration of the guider is cleared as soon as the mount moves. Without this patch, calibration clearing happens only during a meridian flip.

This is a patch for the following forum discussion thread:

Test Plan
  1. Connect the guider to EKOS, start guiding and slew the mount. Check, if guiding aborts and the calibration is cleared.
  2. Same with a schedule for two targets where the guiding task in the scheduler is selected.

Diff Detail

R321 KStars
No Linters Available
No Unit Test Coverage
Build Status
Buildable 19043
Build 19061: arc lint + arc unit
Restricted Application added a project: KDE Edu. · View Herald TranscriptNov 21 2019, 10:34 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Nov 21 2019, 10:34 PM
mutlaqja accepted this revision.Nov 23 2019, 7:47 AM

Been following the thread, great work! Looks good to me.

This revision is now accepted and ready to land.Nov 23 2019, 7:47 AM

One concern that I have about this is that PHD2 today can reuse the same calibration between different observing sessions and at many different positions in the sky. It is supposed to correct for the changes. I'm not totally convinced yet that it does, but every time I have used it since they made that change, it has worked very well. So often you don't want to reset the guiding calibration when using PHD2.

That being said, if that is the case, then I guess you just don't click this option. . .

On the other hand, maybe it would be a good idea to improve the internal guider so that it can reuse the same calibration?

But even if you do improve the internal guider, that doesn't mean folks would not want the option available to redo the calibration every time. Ok I think it makes sense.

lancaster accepted this revision.Nov 26 2019, 7:29 PM
This revision was automatically updated to reflect the committed changes.