Differential D25439

Don't CacheUser/UnCacheUser when editing Realname
ClosedPublic
Actions

Authored by meven on Nov 21 2019, 3:10 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R128:a2f7d308f9b5: Don't CacheUser/UnCacheUser when editing Realname
Summary

1d10226d and 83549151 introduced those lines to follow gnome-control-center example.
Since then gnome-control-center does not call AccountService CacheUser UnCacheUser.

BUG: 392943
FIXED-IN: 5.18

Test Plan
  1. Open user-mananger kcmshell5 user_manager
  2. Ensure to set any picture for your user
  3. Add "1" to your Real name
  4. Click on Apply

Before:
The avatar for your account in the left list is resetted to default setting.

After:
Only the RealName has changed.

Diff Detail

Repository
R128 User Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Nov 21 2019, 3:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 21 2019, 3:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Nov 21 2019, 3:10 PM
ngraham accepted this revision.Nov 21 2019, 4:03 PM

Fantastic. Such a silly bug :p

This revision is now accepted and ready to land.Nov 21 2019, 4:03 PM
Closed by commit R128:a2f7d308f9b5: Don't CacheUser/UnCacheUser when editing Realname (authored by meven). · Explain WhyNov 22 2019, 11:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/lib/accountmodel.cpp (2 lines)

Diff 70153

View Options

src/lib/accountmodel.cpp

Loading...