[plasma-framework] port away from deprecated KF5 APIs
ClosedPublic

Authored by dfaure on Nov 20 2019, 11:18 PM.

Details

Summary

KDeclarative::setupBindings() is deprecated, replaced calls with its
implementation (setupContext + static setupEngine call), but see comment
about whether we can be sure this is done only once per engine, as
requested by the setupEngine API. It's 100% equivalent to the old code
though, can't be worse.

KPackage::contentsHash is deprecated, replaced call with implementation.

Depends on D25433 for the KActionCollection::changed signal.

Test Plan

Builds

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19008
Build 19026: arc lint + arc unit
dfaure created this revision.Nov 20 2019, 11:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 20 2019, 11:18 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Nov 20 2019, 11:18 PM
apol accepted this revision.Dec 14 2019, 10:30 PM
apol added a subscriber: apol.

I'd say we could make it so setupEngine knows itself that it's already been set up.

This revision is now accepted and ready to land.Dec 14 2019, 10:30 PM
dfaure closed this revision.Dec 14 2019, 11:01 PM