use the new GlobalDrawer header property
ClosedPublic

Authored by mart on Nov 20 2019, 5:37 PM.

Details

Summary

Depends on D25425

BUG: 389533
FIXED-IN: 5.18

Test Plan

Diff Detail

Repository
R134 Discover Software Store
Branch
phab/drawerHeader
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18993
Build 19011: arc lint + arc unit
mart created this revision.Nov 20 2019, 5:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 20 2019, 5:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Nov 20 2019, 5:37 PM
mart updated this revision to Diff 70068.Nov 20 2019, 5:38 PM
  • actually use header
mart updated this revision to Diff 70071.Nov 20 2019, 5:49 PM

small fixes

mart edited the test plan for this revision. (Show Details)Nov 20 2019, 5:49 PM
mart added a reviewer: Discover Software Store.
ngraham accepted this revision.Nov 20 2019, 5:53 PM
ngraham edited the summary of this revision. (Show Details)
ngraham added a subscriber: ngraham.

Looks great with D25426!

This revision is now accepted and ready to land.Nov 20 2019, 5:54 PM

Is header: new API? Does this need a kirigami version increase in cmake?

ngraham requested changes to this revision.Nov 20 2019, 5:57 PM
ngraham added inline comments.
discover/qml/DiscoverDrawer.qml
26

2.12 now, right?

This revision now requires changes to proceed.Nov 20 2019, 5:57 PM
apol added a subscriber: apol.Nov 21 2019, 3:20 PM
apol added inline comments.
discover/qml/DiscoverDrawer.qml
158

How's that related? at least the drawerOpen bit should stay.

mart added inline comments.Nov 26 2019, 10:38 AM
discover/qml/DiscoverDrawer.qml
26

there aren't been components registered as 2.12 so far, so technically, it doesn't exist max i can be put there for now is 2.11

158

ok, i can remove it.. not related but most of the manualadjustments discover is doing, it shouldn't, but this is for another topic/patch

mart updated this revision to Diff 70337.Nov 26 2019, 10:40 AM
  • adress comments
apol accepted this revision.Nov 26 2019, 1:27 PM
ngraham accepted this revision.Nov 26 2019, 3:18 PM

Shipit!

This revision is now accepted and ready to land.Nov 26 2019, 3:18 PM
This revision was automatically updated to reflect the committed changes.