header property for the drawer
ClosedPublic

Authored by mart on Nov 20 2019, 5:35 PM.

Details

Reviewers
None
Group Reviewers
Kirigami
Commits
R169:c3e00e58b4ff: header property for the drawer
Summary

GlobalDrawer has the new property header, which does not scroll.
It can be used for toolbars that need to match with the global kirigami toolbar.
the banner image by default is *not* shown on desktop but only on mobile
the result makes easier to make apps look more at home on desktops

Test Plan

apps that don't use it still look the same

Diff Detail

Repository
R169 Kirigami
Branch
mart/drawerHeader
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18991
Build 19009: arc lint + arc unit
mart created this revision.Nov 20 2019, 5:35 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptNov 20 2019, 5:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Nov 20 2019, 5:35 PM
mart edited reviewers, added: Kirigami; removed: Plasma.Nov 20 2019, 5:35 PM

WIP: apidocs still missing

mart planned changes to this revision.Nov 20 2019, 5:36 PM
mart updated this revision to Diff 70070.Nov 20 2019, 5:48 PM
  • single item for header
ngraham added a subscriber: ngraham.
This comment was removed by ngraham.
mart updated this revision to Diff 70072.Nov 20 2019, 5:55 PM
  • apidocs
This revision was not accepted when it landed; it landed in state Needs Review.Nov 26 2019, 3:26 PM
This revision was automatically updated to reflect the committed changes.
ratijas added inline comments.
src/controls/GlobalDrawer.qml
318

What is this contentItem referring to? I'm looking into a bug that header does not collapse when the custom header Item is set to be invisible (search field in Discover).