KF5I18n is required anyway. If it isn't searched and found when the
ki18n_install call, which is injected by the release scripts, is
encountered the build will fail with "CMake Error: No script
specified for argument -P" because a variable usually set by
ki18n_install is not defined.
The same applies to KF5DocTools and kdoctools_install as well, but
it is guarded by a "if (KF5DocTools_FOUND)" so it doesn't error out
but just doesn't install any handbooks, even if KF5DocTools is found.
Details
Details
- Reviewers
cullmann - Group Reviewers
Kate - Commits
- R40:565fd945b52a: Search for KF5I18n and KF5DocTools
The 19.11.80 tarball builds fine with the patch applied
Diff Detail
Diff Detail
- Repository
- R40 Kate
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
CMakeLists.txt | ||
---|---|---|
43 | This doesn't look quite right... did you mean KF5? |
CMakeLists.txt | ||
---|---|---|
43 | Indeed. Sorry and thanks for pointing this out. Corrected with f177bd36372fd06daccd8547869aed3651d43873 |