Search for KF5I18n and KF5DocTools
ClosedPublic

Authored by heikobecker on Nov 19 2019, 7:50 PM.

Details

Summary

KF5I18n is required anyway. If it isn't searched and found when the
ki18n_install call, which is injected by the release scripts, is
encountered the build will fail with "CMake Error: No script
specified for argument -P" because a variable usually set by
ki18n_install is not defined.
The same applies to KF5DocTools and kdoctools_install as well, but
it is guarded by a "if (KF5DocTools_FOUND)" so it doesn't error out
but just doesn't install any handbooks, even if KF5DocTools is found.

Test Plan

The 19.11.80 tarball builds fine with the patch applied

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker created this revision.Nov 19 2019, 7:50 PM
Restricted Application added a project: Kate. · View Herald TranscriptNov 19 2019, 7:50 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
heikobecker requested review of this revision.Nov 19 2019, 7:50 PM
cullmann accepted this revision.Nov 19 2019, 9:06 PM

Thanks!

This revision is now accepted and ready to land.Nov 19 2019, 9:06 PM
This revision was automatically updated to reflect the committed changes.
arojas added a subscriber: arojas.Nov 19 2019, 9:53 PM
arojas added inline comments.
CMakeLists.txt
43

This doesn't look quite right... did you mean KF5?

heikobecker marked an inline comment as done.Nov 19 2019, 10:01 PM
heikobecker added inline comments.
CMakeLists.txt
43

Indeed. Sorry and thanks for pointing this out. Corrected with f177bd36372fd06daccd8547869aed3651d43873