Differential D25403

Drop Position change signal and support Seeked signal
Needs ReviewPublic
Actions

Authored by broulik on Nov 19 2019, 3:23 PM.

Details

Reviewers
fvogt
Group Reviewers
Plasma
Summary

When user seeks, emit Seeked signal. The signal is periodically emitted while seeking and once again when seeking finishes (user releases mouse).
The Position property explicitly isn't signalled as per specification.

Test Plan
  • Moved the seek slider in a video, got the Seeked signal emitted every 250ms, and once again when mouse got released.
  • Position of slider in media controller applets seems consistent

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Nov 19 2019, 3:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 19 2019, 3:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Nov 19 2019, 3:23 PM
fvogt added a comment.Nov 21 2019, 10:56 AM

This would work, but why not just emit Seeked(m_position) in setPosition?

host/mprisplugin.h
55

Could just use MEMBER m_position now?

Revision Contents
Changeset List

PathPackages
Mhost/mprisplugin.h (4 lines)
Mhost/mprisplugin.cpp (20 lines)

Diff 69998

View Options

host/mprisplugin.h

Loading...
View Options

host/mprisplugin.cpp

Loading...