Only save data that needs to be saved and use sanitized data rather than raw text field input.
BUG: 384894
FIXED-IN: 5.18
ngraham | |
davidedmundson |
Plasma |
Only save data that needs to be saved and use sanitized data rather than raw text field input.
BUG: 384894
FIXED-IN: 5.18
Edit Username -> have a PolicyKit password verification
Edit Avatar -> no more password verification popup
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
The commit message looks wrong, maybe you meant PolicyKit? PackageKit should be irrelevant.
Other than that +1
This diff fix this one
I had a look at the others :
Something I noticed when having an avatar and setting any other parameter.
Apparently AccountService removes the icon as it considered it transient cache data :
https://github.com/magcius/accountsservice/blob/eb166ec7592704a897594f7ca4c47b70d871a85c/src/daemon.c#L1105
So it's an upstream issue? Is that really where upstream AccountsService lives? Some random guy's GitHub?
This was a clone of an old version.
Current behavior is the same in the current version.
https://cgit.freedesktop.org/accountsservice/tree/src/daemon.c#n155
Apparently the accountservice daemon wants to uncache the user and in doing so delete data without updating its internal reference.
GNOME does the same as our user-manager but I guess it is not affected.
https://github.com/GNOME/gnome-control-center/blob/f5f67823db5a629fa3ce618bc1d8b80d14f1fc59/panels/user-accounts/cc-avatar-chooser.c#L87
I did some digging but could not pinpoint the problem origin.
In the meantime, I believe this diff is worth merging and might be useful for stable branch even.
Agreed. Works for me and looks safe, but maybe let's do master only for safety.
Can you file a bug upstream on the odd behavior in AccountsService?