Differential D25395

Make avatar icon dpr aware aka HiDPI rendered
ClosedPublic
Actions

Authored by meven on Nov 19 2019, 11:17 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R128:a6f37349cd40: Make avatar icon dpr aware aka HiDPI rendered
Test Plan

Locally tested under Wayland : couldn't make a screenshot because of https://bugs.kde.org/show_bug.cgi?id=409762

Diff Detail

Repository
R128 User Manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18940
Build 18958: arc lint + arc unit
meven created this revision.Nov 19 2019, 11:17 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 19 2019, 11:17 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
meven requested review of this revision.Nov 19 2019, 11:17 AM
meven edited the test plan for this revision. (Show Details)Nov 19 2019, 11:21 AM
crossi added a subscriber: crossi.Nov 19 2019, 2:48 PM
crossi added inline comments.
src/lib/accountmodel.cpp
545

See my previous comment, 'this->' prefix won't be necessary.

src/lib/accountmodel.h
95

Style related, attribute member are prefixed with 'm_', see above declarations.

meven updated this revision to Diff 70008.Nov 19 2019, 5:26 PM

Code style

meven edited the test plan for this revision. (Show Details)Nov 20 2019, 6:58 AM
meven added a reviewer: ngraham.
ngraham accepted this revision.Nov 20 2019, 3:00 PM
This revision is now accepted and ready to land.Nov 20 2019, 3:00 PM
Closed by commit R128:a6f37349cd40: Make avatar icon dpr aware aka HiDPI rendered (authored by meven). · Explain WhyNov 20 2019, 5:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/accountinfo.cpp (4 lines)
Msrc/lib/accountmodel.h (2 lines)
Msrc/lib/accountmodel.cpp (8 lines)

Diff 69982

View Options

src/accountinfo.cpp

Loading...
View Options

src/lib/accountmodel.h

Loading...
View Options

src/lib/accountmodel.cpp

Loading...