Differential D25385

Use icon name instead of pixmap in notification
ClosedPublic
Actions

Authored by nicolasfella on Nov 18 2019, 11:09 PM.

Details

Reviewers
jgrulich
ngraham
Group Reviewers
Plasma
Maniphest Tasks
T11637: KIconThemes Cleanups
Commits
R116:fc443ccedbfc: Use icon name instead of pixmap in notification
Summary

It's both easier and better

Test Plan

builds

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
noti
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18927
Build 18945: arc lint + arc unit
nicolasfella created this revision.Nov 18 2019, 11:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 18 2019, 11:09 PM
Restricted Application added a reviewer: jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
nicolasfella requested review of this revision.Nov 18 2019, 11:09 PM
ngraham accepted this revision.Nov 19 2019, 2:38 AM
jgrulich accepted this revision.Nov 19 2019, 6:39 AM
This revision is now accepted and ready to land.Nov 19 2019, 6:39 AM
Closed by commit R116:fc443ccedbfc: Use icon name instead of pixmap in notification (authored by nicolasfella). · Explain WhyNov 19 2019, 11:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69964

View Options

kded/notification.cpp

Loading...
View Options

libs/editor/connectioneditorbase.cpp

Loading...
View Options

libs/handler.cpp

Loading...