WIP: Beginning of the work for Simplifying the Emoticon KCM
Needs ReviewPublic

Authored by tcanabrava on Nov 18 2019, 8:59 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Before we port this to Qml we need to simplify the code
it's currently monolithycal, and need to be split into at least
two models and a few helper classes.

Load Emoticon from the Models

Problem: Something is *very* heavy. I think creating and
destroying KEmoticons is not the best approach, I'll load
everything and store in memory for next commit

Diff Detail

Repository
R119 Plasma Desktop
Branch
kcm_emoticon
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18963
Build 18981: arc lint + arc unit
tcanabrava created this revision.Nov 18 2019, 8:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 18 2019, 8:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tcanabrava requested review of this revision.Nov 18 2019, 8:59 PM
tcanabrava updated this revision to Diff 70018.Nov 19 2019, 8:12 PM
  • Fix speed of the models
  • Simplify Logic
  • Speed up emoticon loading
  • Re-Enable updateBtn
  • Re-enable remove theme
  • Move more data to the Models
  • Re-enable the rest of the functions
  • Remove ui file

I was under the impression we were killing this KCM in the very near future.

The relevant workboard entry: https://phabricator.kde.org/T7292

I was under the impression we were killing this KCM in the very near future.

The relevant workboard entry: https://phabricator.kde.org/T7292

While the KCM does not die we abandon it?