connect groupbox toggles to change signal
ClosedPublic

Authored by sitter on Nov 18 2019, 2:31 PM.

Details

Summary

the bridge, ppp, and gsm settings contain qgroupboxes which previously
were not tracked

e.g. the STP box toggle on bridges didn't enable the apply button

since checkable qgroupboxes are a fairly generic concept, let's connect a
generic watch rule

Test Plan

toggling STP in bridge settings actually enables apply button

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Nov 18 2019, 2:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 18 2019, 2:31 PM
Restricted Application added 1 blocking reviewer(s): jgrulich. · View Herald Transcript
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sitter requested review of this revision.Nov 18 2019, 2:31 PM

Don't you have to connect to the QGroupBox children? Right now you only connect the QGroupBox itself (which can be checkable) but not the checkboxes within?

jgrulich accepted this revision.Nov 18 2019, 3:10 PM
This revision is now accepted and ready to land.Nov 18 2019, 3:10 PM

@broulik the children are handled by the other connections already (linedit, push button etc.)

This revision was automatically updated to reflect the committed changes.