Port away from deprecated SmallIcon method
ClosedPublic

Authored by yurchor on Nov 17 2019, 8:27 PM.

Details

Summary

SmallIcon is deprecated since KF 5.63

Test Plan

Compiles

Diff Detail

Repository
R443 KImageMapEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor requested review of this revision.Nov 17 2019, 8:27 PM
yurchor created this revision.
aacid added a subscriber: aacid.Nov 17 2019, 8:35 PM

Are you sure that's how we need to port the code?

If this is it, i would really fight the deprecation, i mean that's "super complicated" code.

Maybe it works the same just with QIcon::fromTheme? That'd be a "sensible" port, i.e. one that didn't make the app code harder to write/read

yurchor updated this revision to Diff 69892.Nov 17 2019, 8:45 PM

Get rid of extra complication

aacid accepted this revision.Nov 17 2019, 8:46 PM

If you have checked and it looks the same, i'd say go for it

This revision is now accepted and ready to land.Nov 17 2019, 8:46 PM
This revision was automatically updated to reflect the committed changes.