Differential D25348

Download kdelibs and kde-dev-scripts containing required scripts
ClosedPublic
Actions

Authored by aspotashev on Nov 16 2019, 10:36 PM.

Details

Reviewers
aacid
Group Reviewers
Localization
Commits
R883:1558238: Download kdelibs and kde-dev-scripts containing required scripts
Summary

update_translations depends on scripts from kdelibs and kde-dev-scripts: preparetips, svn-clean, etc.

Test Plan

trunk/kde-common/makemessages works without pulling kdelibs and kde-dev-scripts manually.

Diff Detail

Repository
R883 Subversion
Lint
Lint Skipped
Unit
Unit Tests Skipped
aspotashev requested review of this revision.Nov 16 2019, 10:36 PM
aspotashev created this revision.
ltoscano added a subscriber: ltoscano.Nov 17 2019, 2:36 PM

What is the gain? This branch can stay as it.

aspotashev added a comment.Nov 17 2019, 6:36 PM

Well, this is a bug fix. Without this patch preparetips and svn-clean won't run unless you cloned the two mentioned repos manually.

aacid added a subscriber: aacid.Nov 27 2019, 10:50 PM

i can see this is a potential bugfix, but honestly, i'd just leave the kde4 branches die (unless this is blocking you heavily in some way)

aspotashev added a comment.Dec 3 2019, 2:11 PM
In D25348#568616, @aacid wrote:

i can see this is a potential bugfix, but honestly, i'd just leave the kde4 branches die (unless this is blocking you heavily in some way)

It's not blocking me heavily, but it annoys me because the patch sits in my local Git history and slightly distracts me from other tasks.

aacid accepted this revision.Dec 11 2019, 10:47 PM

ok, fair enough, let's go for it, but if you break something you fix it yesterday ;)

This revision is now accepted and ready to land.Dec 11 2019, 10:47 PM
aspotashev closed this revision.Dec 12 2019, 7:51 PM
aspotashev reopened this revision.Dec 12 2019, 7:51 PM
This revision is now accepted and ready to land.Dec 12 2019, 7:51 PM
aspotashev closed this revision.Dec 12 2019, 7:53 PM
aspotashev added a comment.Dec 13 2019, 2:04 AM

Looks like it resulted in a new empty dir templates/messages/kdesdk/. Not a big problem though.

Revision Contents
Changeset List

Diff 69863

View Options

branches/stable/l10n-kde4/scripts/get_paths

Loading...
View Options

branches/stable/l10n-kde4/scripts/update_translations

Loading...