Differential D25336

Revert "[GTK3] Revert checkbox recolouring"
ClosedPublic
Actions

Authored by cblack on Nov 16 2019, 3:38 PM.

Details

Reviewers
ngraham
Group Reviewers
Breeze
VDG
Commits
R98:980ceeb25b44: Revert "[GTK3] Revert checkbox recolouring"
Summary

This reverts commit b1649126c8c6d1af746a8472939fcda40a260095, as an upstream librsvg bug was fixed, allowing checkboxes and radiobuttons to recolour properly.

https://gitlab.gnome.org/GNOME/librsvg/issues/525

Test Plan

See that checkbox recolouring works as expected.

Diff Detail

Repository
R98 Breeze for Gtk
Branch
reintroduce-cbox-recolour (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18850
Build 18868: arc lint + arc unit
cblack created this revision.Nov 16 2019, 3:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 16 2019, 3:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Nov 16 2019, 3:38 PM
ngraham added a subscriber: ngraham.Nov 16 2019, 3:40 PM

For history's sake, can you add a comment regarding what changed to make this work properly now?

cblack edited the summary of this revision. (Show Details)Nov 16 2019, 3:40 PM
ngraham added a comment.Nov 16 2019, 3:46 PM

Thanks! Can you add a link to the bugfix in the description section so it's easy to reference? And has the upstream bugfix made it into a release yet such that we can count on it being present for users with rolling release distros, or users whose discrete-release distros eventually settle on Plasma 5.18?

cblack edited the summary of this revision. (Show Details)Nov 16 2019, 3:49 PM
In D25336#563292, @ngraham wrote:

Thanks! Can you add a link to the bugfix in the description section so it's easy to reference? And has the upstream bugfix made it into a release yet such that we can count on it being present for users with rolling release distros, or users whose discrete-release distros eventually settle on Plasma 5.18?

There's been a few releases since the bugfix was landed in librsvg.

ngraham accepted this revision.Nov 16 2019, 4:16 PM

5.18 only please!

This revision is now accepted and ready to land.Nov 16 2019, 4:16 PM
Closed by commit R98:980ceeb25b44: Revert "[GTK3] Revert checkbox recolouring" (authored by cblack). · Explain WhyNov 16 2019, 4:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69842

View Options

src/gtk3/widgets/_checkboxes.scss

Loading...
View Options

src/gtk3/widgets/_menus.scss

Loading...