Revert "[GTK3] Revert checkbox recolouring"
ClosedPublic

Authored by cblack on Sat, Nov 16, 3:38 PM.

Details

Summary

This reverts commit b1649126c8c6d1af746a8472939fcda40a260095, as an upstream librsvg bug was fixed, allowing checkboxes and radiobuttons to recolour properly.

https://gitlab.gnome.org/GNOME/librsvg/issues/525

Test Plan

See that checkbox recolouring works as expected.

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cblack created this revision.Sat, Nov 16, 3:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSat, Nov 16, 3:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Sat, Nov 16, 3:38 PM

For history's sake, can you add a comment regarding what changed to make this work properly now?

cblack edited the summary of this revision. (Show Details)Sat, Nov 16, 3:40 PM

Thanks! Can you add a link to the bugfix in the description section so it's easy to reference? And has the upstream bugfix made it into a release yet such that we can count on it being present for users with rolling release distros, or users whose discrete-release distros eventually settle on Plasma 5.18?

cblack edited the summary of this revision. (Show Details)Sat, Nov 16, 3:49 PM

Thanks! Can you add a link to the bugfix in the description section so it's easy to reference? And has the upstream bugfix made it into a release yet such that we can count on it being present for users with rolling release distros, or users whose discrete-release distros eventually settle on Plasma 5.18?

There's been a few releases since the bugfix was landed in librsvg.

ngraham accepted this revision.Sat, Nov 16, 4:16 PM

5.18 only please!

This revision is now accepted and ready to land.Sat, Nov 16, 4:16 PM
This revision was automatically updated to reflect the committed changes.