Show startup error in popup as well
ClosedPublic

Authored by broulik on Nov 15 2019, 10:31 AM.

Details

Summary

When the host crashes, the error message is shown to the user. When startup fails, only a generic message is shown.
This adds the error message provided by the browser to aid debugging the problem.

Test Plan
  • Sabotaged my browser host, got the icon crossed-out, got "native host not found" in the popup. There was no badge because the icon is crossed out already and the error never cleared
  • Fixed my host, got normal plasma icon with generic popup icon (no behavior change)
  • Killed my host, got a "!" badge with the error which was cleared when the popup was closed (no behavior change)

Diff Detail

Repository
R856 Plasma Browser Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 15 2019, 10:31 AM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 15 2019, 10:31 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Nov 15 2019, 10:31 AM
fvogt accepted this revision.Nov 15 2019, 10:43 AM

I wonder whether the getStatus handler could be cleaned up by removing the UNKNOWN value of portStatus and removing the default: case.

This revision is now accepted and ready to land.Nov 15 2019, 10:43 AM
This revision was automatically updated to reflect the committed changes.