Fix issues from D24798 comments by @davidedmundson
ClosedPublic
Actions

Authored by guoyunhe on Nov 15 2019, 9:21 AM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

Summary

Lower QQC2 version to minimum requirement. Add context to i18nc function. Cannot use i18ncp because the number isn't integer.

Repository

R120 Plasma Workspace

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

guoyunhe requested review of this revision.Nov 15 2019, 9:21 AM

davidedmundson requested changes to this revision.Nov 15 2019, 9:31 AM

davidedmundson added inline comments.

applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
134	The important part was the I18np that handles "1 second" Vs "2 secondS"

This revision now requires changes to proceed.Nov 15 2019, 9:31 AM

Cannot use i18ncp because the number isn't integer.

Oh, I see.

This revision is now accepted and ready to land.Nov 15 2019, 10:30 AM

This revision was automatically updated to reflect the committed changes.

toFixed() makes decimal separator always a point, thus not localizable. We need something else to support point or comma depending on the locale.

			Path	Packages
M			applets/digital-clock/package/contents/ui/configTimeZones.qml (2 lines)
M			applets/systemmonitor/common/contents/ui/ConfigGeneral.qml (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69787	b7b2501		Nov 15 2019, 9:21 AM	★	★
Diff 2	69803	dac6be5	R120:df49734ff99195722e181320c4996d6d0e37a254	Nov 15 2019, 12:48 PM	★	★