[Notifications KCM] Fix keyboard navigation in apps list
ClosedPublic

Authored by ngraham on Nov 14 2019, 5:49 PM.

Details

Summary

Learned how to do this from @guoyunhe in D24798!

BUG: 409024
FIXED-IN: 5.17.4

Test Plan
  1. Click on list item -> list gets focus, item is shown
  2. Use up and down arrow keys -> items are shown
  3. Click on search field and tab into list -> you can select things with the keyboard
  4. Search for something and click on or tab into apps list -> the correct item is shown

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Nov 14 2019, 5:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 14 2019, 5:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Nov 14 2019, 5:49 PM
broulik added inline comments.Nov 14 2019, 6:00 PM
kcms/notifications/package/contents/ui/SourcesPage.qml
147

Why this?

150–151

Can you try avoiding this code duplication? Does setting the currentIndex of the ListView here work?

ngraham updated this revision to Diff 69761.Nov 14 2019, 6:19 PM
ngraham marked 2 inline comments as done.

Address review comments

broulik accepted this revision.Nov 15 2019, 7:56 AM
This revision is now accepted and ready to land.Nov 15 2019, 7:56 AM
This revision was automatically updated to reflect the committed changes.