when kioslave5 couldn't be found in libexec-ish locations try $PATH
ClosedPublic

Authored by sitter on Nov 14 2019, 5:37 PM.

Details

Summary

on windows we install the binary to bin/ where software that uses kio
can find it through applicationDirPath() ordinarily. at test-time however
applicationDirPath() of the test != finalPath, so the only way a test
can possibly find the helper is through $PATH.

this should fix the drkonqi connection test on win32 on build.kde.org

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Nov 14 2019, 5:37 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 14 2019, 5:37 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Nov 14 2019, 5:37 PM
apol accepted this revision.Nov 15 2019, 3:30 PM
This revision is now accepted and ready to land.Nov 15 2019, 3:30 PM
anthonyfieroni added inline comments.
src/core/slave.cpp
521

Remove QString declaration before.

This revision was automatically updated to reflect the committed changes.