[platforms/x11/standalone] Use intel swap events by default
ClosedPublic

Authored by romangg on Nov 14 2019, 8:29 AM.

Details

Summary

Activate intel swap events by default if available. They were hidden behind an
environmental variable because of some critical release blocking issue years
ago.

Manual testing indicates that there are no issues anymore with this extension.
Since it allows us to use swap events with MESA drivers for optimized repaints
enable swap events by default again.

For now leave a modified environment variable to switch back to using no swap
events easily.

CCBUG: 342582

Test Plan

i915

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Nov 14 2019, 8:29 AM
Restricted Application added a project: KWin. · View Herald TranscriptNov 14 2019, 8:29 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Nov 14 2019, 8:29 AM

Please document any such environment variables in https://community.kde.org/KWin/Environment_Variables

zzag added a subscriber: zzag.Nov 18 2019, 7:42 AM
zzag added inline comments.
plugins/platforms/x11/standalone/glxbackend.cpp
213

Please don't introduce yet another environment variable, just check whether KWIN_USE_INTEL_SWAP_EVENT is not "0".

This revision was not accepted when it landed; it landed in state Needs Review.Dec 12 2019, 12:57 AM
This revision was automatically updated to reflect the committed changes.
romangg marked an inline comment as done.