Move implementation of iconGeometry from ShellClient to AbstractClient
ClosedPublic

Authored by graesslin on Aug 22 2016, 3:00 PM.

Details

Summary

This allows Client to use the Wayland-specific implementation if there
is no icon geometry set through the X11 way. That way Xwayland windows
have an icon geometry even if Plasma is using Wayland and setting the
icon geometry in the Wayland way. Which is expected as Plasma is
ignorant about the windowing system a PlasmaWindow uses.

In order to move the code from ShellClient to AbstractClient
WaylandServer gained a new findAbstractClient(Surface*) method which
is just like findClient(Surface*) with the difference that it returns
an AbstractClient instead of a ShellClient*.

Test Plan

minimized/unminimized an X client on Wayland, verified
animation is correct (though broken in general for minimize)

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 6148.Aug 22 2016, 3:00 PM
graesslin retitled this revision from to Move implementation of iconGeometry from ShellClient to AbstractClient.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma on Wayland.
Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptAug 22 2016, 3:00 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
hein accepted this revision.Aug 22 2016, 3:02 PM
hein added a reviewer: hein.
This revision is now accepted and ready to land.Aug 22 2016, 3:02 PM
This revision was automatically updated to reflect the committed changes.