Differential D25297

Add guards for m_terminalPanel
AbandonedPublic
Actions

Authored by broulik on Nov 14 2019, 7:49 AM.

Details

Reviewers
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Summary

BUG: 414101
FIXED-IN: 19.12.0

Test Plan

There was a fix for this in 29778152adc5cd81377a80cf606a1fae008e9bfc but sadly it wasnt in stable, so we're stuck with this until 19.12, or is there another 19.08 release?

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Nov 14 2019, 7:49 AM
Restricted Application added a project: Dolphin. · View Herald TranscriptNov 14 2019, 7:49 AM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
broulik requested review of this revision.Nov 14 2019, 7:49 AM
broulik edited the summary of this revision. (Show Details)Nov 14 2019, 9:57 AM
ngraham accepted this revision.Nov 14 2019, 2:32 PM
ngraham added a subscriber: ngraham.

There's no other 19.08 release planned, but you can request an exception from the release team if this fixes a high profile issue.

This revision is now accepted and ready to land.Nov 14 2019, 2:32 PM
broulik added a comment.Nov 14 2019, 2:53 PM

Don't think it's highprofile, just a bit annoying that an obvious one liner bugfix wasn't pushed to stable

elvisangelaccio accepted this revision.Nov 14 2019, 9:23 PM
broulik abandoned this revision.Nov 18 2019, 8:49 AM

Looks like those fixes are already in master

Revision Contents
Changeset List

PathPackages
Msrc/dolphinmainwindow.cpp (6 lines)

Diff 69721

View Options

src/dolphinmainwindow.cpp

Loading...