The icon's old margins were too large, causing it to stick out.
BUG: 400087
FIXED-IN: 5.66
Details
Details
- Reviewers
ndavis - Group Reviewers
VDG - Commits
- R242:5172b920f9e1: [RFC] Fix Display Configuration icon margins
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- fix-xrandr-icon (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 18776 Build 18794: arc lint + arc unit
Comment Actions
It's blurry in your screenshot because you're scaling a 22px icon up to 32px. The solution is to make a 32px version named 32-32-preferences-desktop-display-randr. BTW, the icon is not actually aligned with the grid. It's a little off here and there. You should be able to fix it easily with the node tool by snapping nodes to the grid.
| src/desktoptheme/breeze/icons/preferences.svg | ||
|---|---|---|
| 4 | Wrong default colors. Just replace the whole stylesheet with this one: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Breeze | |
| 36 | You have 2 embedded stylesheets, although I doubt the 2nd one actually works since the ID isn't correct. You can delete the 2nd one. | |
| 73 | Hardcoded color | |
| 74 | Hardcoded color. Inkscape does this to any element of the SVG you modify. | |
Comment Actions
- Fix stylesheet and color-changing ability
- Align to grid; vertical lines still blurry, not sure why
Comment Actions
Never mind, I wasn't deleting the cache files properly after rebuilding. When I do that, the monochrome icons don't get used at all and it reverts to the colorful one:
Comment Actions
Never mind, I wasn't deleting the cache files properly after rebuilding. When I do that, the monochrome icons don't get used at all and it reverts to the colorful one:
The color vs monochrome issue strikes again :(
Maybe remove the size prefix from the 32px version? If that doesn't work, I've got nothing.