Integrate the lnf and wallpaper settings with the KCM logic
ClosedPublic
Actions

Authored by ervin on Nov 13 2019, 2:48 PM.

Details

Reviewers

Group Reviewers

Plasma

Commits

Summary

This was currently very much disconnected and broken in quite a few
cases. The main changes here are:

Further improvement is needed to simplify the handling of the wallpaper
plugin combo, it's still a bit over the place and fragile.

Repository

R133 KScreenLocker

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

ervin requested review of this revision.Nov 13 2019, 2:48 PM

Adjust for bugs found in the lnf and wallpaper integration

This was missing some signalling and copying back in the item

Fix typo

This revision is now accepted and ready to land.Nov 27 2019, 4:07 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			greeter/lnf_integration.h (3 lines)
M			greeter/lnf_integration.cpp (1 line)
M			greeter/wallpaper_integration.h (3 lines)
M			greeter/wallpaper_integration.cpp (1 line)
M			kcm/kcm.h (6 lines)
M			kcm/kcm.cpp (77 lines)
M			kcm/lnfconfig.qml (29 lines)
M			kcm/wallpaperconfig.qml (29 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	69678	68bdeb8		Nov 13 2019, 2:48 PM	★	★
Diff 2	70429	f368ffa	Adjust for bugs found in the lnf and wallpaper integration	Nov 27 2019, 2:59 PM	★	★
Diff 3	70432	f368ffa	Fix typo	Nov 27 2019, 3:15 PM	★	★
Diff 4	70483	f368ffa	R133:33857261ccd7c9457e63f96b00add54b2ef60cfd	Nov 28 2019, 9:26 AM	★	★