Differential D2528

Add support for Surface enter/leave events
ClosedPublic
Actions

Authored by graesslin on Aug 22 2016, 12:21 PM.

Details

Reviewers

sebas

Group Reviewers

Plasma on Wayland

Commits

R127:4f9dae46b424: Add support for Surface enter/leave events

Summary

This change implements support for the wl_surface events enter and
leave. Those events are emitted whenever a surface becomes visible on
an output by e.g. mapping the surface, moving or resizing it. Similar
the leave is sent whenever the surface is no longer on an output.

The server side is not yet fully complete yet. It also needs to emit
when the client binds the output another time and needs to send a
leave before destroying the output.

Diff Detail

Repository

R127 KWayland

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 6139.Aug 22 2016, 12:21 PM

graesslin retitled this revision from to Add support for Surface enter/leave events.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma on Wayland.

Restricted Application added a project: Plasma on Wayland. · View Herald TranscriptAug 22 2016, 12:21 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

graesslin added a dependency: D2526: [client] Track all created Outputs and add static get method.Aug 22 2016, 12:22 PM

sebas accepted this revision.Sep 12 2016, 12:47 PM

sebas added a reviewer: sebas.

sebas added a subscriber: sebas.

sebas added inline comments.

src/client/surface.cpp
50	Output*
src/client/surface.h
247	Output* ?

This revision is now accepted and ready to land.Sep 12 2016, 12:47 PM

Closed by commit R127:4f9dae46b424: Add support for Surface enter/leave events (authored by graesslin). · Explain WhySep 13 2016, 6:33 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/client/test_wayland_surface.cpp (75 lines)
M			src/client/output.h (1 line)
M			src/client/surface.h (31 lines)
M			src/client/surface.cpp (53 lines)
M			src/server/output_interface.h (7 lines)
M			src/server/output_interface.cpp (12 lines)
M			src/server/surface_interface.h (18 lines)
M			src/server/surface_interface.cpp (38 lines)
M			src/server/surface_interface_p.h (2 lines)