Differential D25274

KCM LookAndFeel : port to KConfig XT
ClosedPublic
Actions

Authored by crossi on Nov 12 2019, 3:42 PM.

Details

Reviewers
ervin
mart
bport
davidedmundson
Group Reviewers
Plasma
Commits
R119:613d5e12871c: KCM LookAndFeel : port to KConfig XT

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 18719
Build 18737: arc lint + arc unit
crossi created this revision.Nov 12 2019, 3:42 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 12 2019, 3:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Nov 12 2019, 3:42 PM
crossi updated this revision to Diff 69642.Nov 12 2019, 3:43 PM

Add kcfg files

ervin requested changes to this revision.Nov 12 2019, 3:53 PM

Just a recurring typo, otherwise LGTM

kcms/lookandfeel/kcm.cpp
220

s/fell/feel/ :-)

kcms/lookandfeel/kcm.h
38

s/Fell/Feel/

64

s/Fell/Feel/

kcms/lookandfeel/package/contents/ui/main.qml
32

s/Fell/Feel/

58

s/Fell/Feel/

This revision now requires changes to proceed.Nov 12 2019, 3:53 PM
crossi updated this revision to Diff 69643.Nov 12 2019, 4:00 PM

misspelling

davidedmundson accepted this revision.Nov 12 2019, 4:21 PM
ervin accepted this revision.Nov 15 2019, 7:07 AM
This revision is now accepted and ready to land.Nov 15 2019, 7:07 AM
Closed by commit R119:613d5e12871c: KCM LookAndFeel : port to KConfig XT (authored by crossi). · Explain WhyNov 25 2019, 9:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69641

View Options

kcms/lookandfeel/CMakeLists.txt

Loading...
View Options

kcms/lookandfeel/autotests/CMakeLists.txt

Loading...
View Options

kcms/lookandfeel/kcm.h

Loading...
View Options

kcms/lookandfeel/kcm.cpp

Loading...
View Options

kcms/lookandfeel/lnftool.cpp

Loading...
View Options

kcms/lookandfeel/package/contents/ui/main.qml

Loading...