By using KColorSchemeManager we can enable viewing icons with all installed
color schemes. Also all the color setting everywhere can be dropped.
Details
- Reviewers
ngraham - Group Reviewers
Plasma - Commits
- R118:2d8d17a7b4e6: Enable selecting all installed color schemes in Cuttlefish
Diff Detail
- Repository
- R118 Plasma SDK
- Branch
- colorschemes (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 21639 Build 21657: arc lint + arc unit
cuttlefish/src/main.cpp | ||
---|---|---|
145 | Moving the setting of the context properties before loading of the file fixes these being unavailable at the beginning. => Less errors on startup and we can select the the current color scheme on startup because the index isn't reset when the color scheme model becomes available. |
Nice, it's good to get rid of so much boilerplate.
However when I change the system's own color scheme from Breeze to anything else and start Cuttlefish, the app itself uses that color scheme as expected, but the combobox's text is blank:
Also, the combobox's model appears to have duplicates for Breeze, Breeze Dark, and Breeze Light, which (correctly) don't show up in the colors KCM for me:
I see what's happening. I copied that code form Kate and it reads the current color scheme name from kdeglobals but there can be a difference between the stored name and the user visible name. Especially when it includes a space or hyphen. So it works correctly for Breeze or Oxygen but not Breeze Dark or Oxygen cold.
Since this directly uses KColorSchemeManager, do you also see duplicated entries in Kate's color scheme menu?
I think I know what's happening. Do you have Breeze installed into the same prefix as cuttlefish in addition to system breeze? After doing so I also see the duplicate color. (The same happens in Kate)
- remove default color scheme, system theme support in kcolorschememanager, also display icons
Ping since system theme support is now in frameworks and plasma master can depend on frameworks master
Bad combobox width strikes again (https://bugs.kde.org/show_bug.cgi?id=403153), worsened by adding an icon:
Also, gross, there are duplicates
cuttlefish/src/main.cpp | ||
---|---|---|
139 | typo causes a build failure |
Bah we should fix it finally if possible
Also, gross, there are duplicates
See above. Something to fix in KColorSchemeManager to not load the same theme twice if it has the same name as another one. (As the Colors KCM does)