Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews
ClosedPublic

Authored by leinir on Nov 12 2019, 1:32 PM.

Details

Summary

This adds a new property which allows the user to ask the model
to filter its contents by whether or not a comment has a rating
(which means we consider it a review), and optionally to include
the replies to those reviews.

The filtering options are added as contextual actions on the
comments page, so they easily integrate with the Kirigami-esque
navigation methods

Test Plan

Without patch: No way to only show reviews
With patch: Button(s) appear(s) on the page which shows reviews and comments to allow switching between showing comments, only reviews, or reviews and their replies

Diff Detail

Repository
R304 KNewStuff
Branch
allow-filtering-comments-by-rating-state (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18713
Build 18731: arc lint + arc unit
leinir created this revision.Nov 12 2019, 1:32 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 12 2019, 1:32 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Nov 12 2019, 1:32 PM
leinir edited the test plan for this revision. (Show Details)Nov 12 2019, 1:34 PM
leinir added reviewers: Plasma, KNewStuff, Frameworks.
leinir edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Nov 26 2019, 12:46 PM
This revision is now accepted and ready to land.Nov 26 2019, 12:46 PM
This revision was automatically updated to reflect the committed changes.