Support adding a contact to a specific backend
Needs ReviewPublic
Actions

Authored by jbbgameich on Nov 11 2019, 8:22 PM.

Details

Reviewers

apol

Group Reviewers

Plasma: Mobile

Summary

Add overload of PersonPluginManager::addContact that takes a pluginId
Add a DataSourceModel that can later be extended with additional metadata on the backends.

Test Plan

Repository

R307 KPeople

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 18708
Build 18726: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

jbbgameich requested review of this revision.Nov 11 2019, 8:22 PM

Use more future proof roleNames and Enum

src/datasourcemodel.h
43	Use DisplayRole for this?
src/personpluginmanager.h
91	include @param
96	I wonder if that's the best API. Would it make sense to have separate setDefaultSource(QString) and addContact(QVariantMap properties). The default source could even come from a setting in the system.

src/datasourcemodel.h
43	I intend to add an actual display role later. Strictly speaking this is the id used by KPeople and not anything that should be shown to the user ideally.

		Path
M		src/CMakeLists.txt (2 lines)
A	M	src/datasourcemodel.h (56 lines)
A	M	src/datasourcemodel.cpp (58 lines)
M		src/declarative/peopleqmlplugin.cpp (5 lines)
M		src/personpluginmanager.h (9 lines)
M		src/personpluginmanager.cpp (17 lines)