Differential D25263

[ComboBox] Don't dim Popup
ClosedPublic
Actions

Authored by broulik on Nov 11 2019, 7:09 PM.

Details

Reviewers
mart
ngraham
davidedmundson
Group Reviewers
Plasma
Commits
R858:d11ba447fa78: [ComboBox] Don't dim Popup
Summary

The dimming only works with pure QML applications based on ApplicationWindow which is why it didn't do anything in System Settings. However, in Kirigami Gallery the entire window darkens unexpectedly.

Test Plan

ComboBox in Kirigami gallery behaves normally now

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Nov 11 2019, 7:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 11 2019, 7:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Nov 11 2019, 7:09 PM
ngraham accepted this revision.Nov 11 2019, 8:20 PM
ngraham added a subscriber: ngraham.

Good riddance IMO. :)

This revision is now accepted and ready to land.Nov 11 2019, 8:20 PM
davidedmundson accepted this revision.Nov 11 2019, 8:32 PM
Closed by commit R858:d11ba447fa78: [ComboBox] Don't dim Popup (authored by broulik). · Explain WhyNov 12 2019, 7:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Morg.kde.desktop/ComboBox.qml (1 line)

Diff 69623

View Options

org.kde.desktop/ComboBox.qml

Loading...