[sddm-theme] Fix initial focus after SDDM QQC2 Port
ClosedPublic

Authored by davidedmundson on Nov 11 2019, 3:43 PM.

Details

Summary

QQC2 StackView has a major behavioural difference

QQuickStackViewPrivate::setCurrentItem

item->setFocus(true);

This as a general rule makes sense, especially if you're pushing a whole
focus scope onto the stackView, it would automatically select the right
element. However as our base was not a focus scope the
SessionManagementScreen instance itself got focus, taking it away from
the child password box.

LockScreenUi has to be changed so that it sets the initial focus the
same even though the stackview is on QQC1.

Test Plan

qmlscene in the sddm-theme directory with the dummydata setup
locked the screen regularly

Lots of gammaray

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Nov 11 2019, 3:43 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 11 2019, 3:43 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Nov 11 2019, 3:43 PM

Seems to work

ngraham accepted this revision.Nov 12 2019, 2:21 PM
This revision is now accepted and ready to land.Nov 12 2019, 2:21 PM
This revision was automatically updated to reflect the committed changes.