diff --git a/src/tests/dolphinsearchboxtest.cpp b/src/tests/dolphinsearchboxtest.cpp --- a/src/tests/dolphinsearchboxtest.cpp +++ b/src/tests/dolphinsearchboxtest.cpp @@ -1,5 +1,6 @@ /*************************************************************************** * Copyright (C) 2011 by Peter Penz * + * Copyright (C) 2019 by Ismael Asensio * * * * This program is free software; you can redistribute it and/or modify * * it under the terms of the GNU General Public License as published by * @@ -18,9 +19,21 @@ ***************************************************************************/ #include "search/dolphinsearchbox.h" +#include "search/dolphinquerymodel.h" #include +#include +#ifdef HAVE_BALOO +#include +#include +#include +#include +#include +#include +#include +#endif + class DolphinSearchBoxTest : public QObject { Q_OBJECT @@ -30,14 +43,18 @@ void cleanup(); void testTextClearing(); - +#ifdef HAVE_BALOO + void testBalooSearchParsing_data(); + void testBalooSearchParsing(); +#endif private: DolphinSearchBox* m_searchBox; }; void DolphinSearchBoxTest::init() { m_searchBox = new DolphinSearchBox(); + m_searchBox->show(); //required to initialize the searchbox widgets } void DolphinSearchBoxTest::cleanup() @@ -64,6 +81,120 @@ QVERIFY(m_searchBox->text().isEmpty()); } +#ifdef HAVE_BALOO +/** + * Defines the parameters for the test cases in testBalooSearchParsing() + */ +void DolphinSearchBoxTest::testBalooSearchParsing_data() +{ + const Baloo::IndexerConfig searchInfo; + if (!searchInfo.fileIndexingEnabled()) { + QSKIP("Baloo is not available. Not-indexed search is used instead"); + } + + const QString text = QStringLiteral("xyz"); + const QString filename = QStringLiteral("filename:\"xyz\""); + const QString rating = QStringLiteral("rating>=2 "); + const QString modified = QString("modified>=%1 ").arg(QDate::currentDate().toString(Qt::DateFormat::ISODate)); + + QTest::addColumn("searchString"); + QTest::addColumn("expectedText"); + QTest::addColumn("expectedTerms"); + + // Test for "Content" + QTest::newRow("content") << text << text << QStringList(); + QTest::newRow("content/empty") << "" << "" << QStringList(); + QTest::newRow("content/singleQuote") << "\"" << "" << QStringList(); + QTest::newRow("content/doubleQuote") << "\"\"" << "" << QStringList(); + // Test for empty `filename` + QTest::newRow("filename") << filename << text << QStringList(); + QTest::newRow("filename/empty") << "filename:" << "" << QStringList(); + QTest::newRow("filename/singleQuote") << "filename:\"" << "" << QStringList(); + QTest::newRow("filename/doubleQuote") << "filename:\"\"" << "" << QStringList(); + + // Test for rating + QTest::newRow("rating") << rating << "" << QStringList({rating}); + QTest::newRow("rating+content") << rating + text << text << QStringList({rating}); + QTest::newRow("rating+filename") << rating + filename << text << QStringList({rating}); + // Test for modified date + QTest::newRow("modified") << modified << "" << QStringList({modified}); + QTest::newRow("modified+content") << modified + text << text << QStringList({modified}); + QTest::newRow("modified+filename") << modified + filename << text << QStringList({modified}); + // Combined tests + QTest::newRow("rating+modified") << rating + "AND " + modified << "" << QStringList({modified, rating}); + QTest::newRow("rating+modified+content") << rating + "AND " + modified + text << text << QStringList({modified, rating}); + QTest::newRow("rating+modified+filename") << rating + "AND " + modified + filename << text << QStringList({modified, rating}); +} + +/** + * Helper function to compose the baloo query URL used for searching + */ +QUrl _composeQueryUrl(const QString searchString) +{ + QJsonObject jsonObject { + {"searchString", searchString} + }; + + QJsonDocument doc(jsonObject); + QByteArray docByteArray = doc.toJson(QJsonDocument::Compact); + QString queryString = QLatin1String(docByteArray); + + QUrlQuery urlQuery; + urlQuery.addQueryItem(QStringLiteral("json"), queryString); + + QUrl searchUrl; + searchUrl.setScheme(QLatin1String("baloosearch")); + searchUrl.setQuery(urlQuery); + + return searchUrl; +} + +/** + * The test verifies whether the different terms of a Baloo search URL ("baloosearch:") are + * properly handled by the searchbox, and only "user" or filename terms are added to the + * text bar of the searchbox. + */ +void DolphinSearchBoxTest::testBalooSearchParsing() +{ + QFETCH(QString, searchString); + QFETCH(QString, expectedText); + QFETCH(QStringList, expectedTerms); + + QUrl testUrl = _composeQueryUrl(searchString); + DolphinQueryModel queryModel = DolphinQueryModel::fromBalooSearchUrl(testUrl); + + QStringList searchTerms = queryModel.searchTerms(); + searchTerms.sort(); + + // FIXME: Current parsing bugs + QEXPECT_FAIL("content/singleQuote", "Quotes around text are shown", Continue); + QEXPECT_FAIL("content/doubleQuote", "Quotes around text are shown", Continue); + + QEXPECT_FAIL("filename", "Quotes around text are shown", Continue); + QEXPECT_FAIL("filename/singleQuote", "Quotes around text are shown", Continue); + QEXPECT_FAIL("filename/doubleQuote", "Quotes around text are shown", Continue); + + QEXPECT_FAIL("rating" , "Text includes also search terms", Continue); + QEXPECT_FAIL("rating+content" , "Text includes also search terms", Continue); + QEXPECT_FAIL("rating+filename" , "Text includes also search terms", Continue); + QEXPECT_FAIL("modified" , "Text includes also search terms", Continue); + QEXPECT_FAIL("modified+content" , "Text includes also search terms", Continue); + QEXPECT_FAIL("modified+filename" , "Text includes also search terms", Continue); + QEXPECT_FAIL("rating+modified" , "Text includes also search terms", Continue); + QEXPECT_FAIL("rating+modified+content" , "Text includes also search terms", Continue); + QEXPECT_FAIL("rating+modified+filename", "Text includes also search terms", Continue); + + // Check for parsed text (would be displayed on the input search bar) + QCOMPARE(queryModel.text(), expectedText); + + // Check for parsed search terms (would be displayed by the facetsWidget) + QCOMPARE(searchTerms.count(), expectedTerms.count()); + for (int i=0; i < expectedTerms.count(); i++) { + QCOMPARE(searchTerms.at(i).trimmed(), expectedTerms.at(i).trimmed()); + } +} +#endif //HAVE_BALOO + QTEST_MAIN(DolphinSearchBoxTest) #include "dolphinsearchboxtest.moc"