Split handling of on-demand extractor process from IndexedDataRetriever
ClosedPublic

Authored by bruns on Nov 11 2019, 1:34 AM.

Details

Summary

To allow a unification of the IndexedDataRetriever job and FileFetchJob,
move the process handling into a separate class and only keep
the UserMetaData handling.

As a small optimization, interleave the forking of the external process,
UserMetaData retrieval and joining of the external process. Also reuse
the QFileInfo in the constructor to determine if the file is writable and
thus has editable metadata.

Beyond the optimization, no user visible changes.

Depends on D25247

Test Plan

When using a location not indexed by baloo, metadata is
still shown as before

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Nov 11 2019, 1:34 AM
Restricted Application added a project: Baloo. · View Herald TranscriptNov 11 2019, 1:34 AM
bruns requested review of this revision.Nov 11 2019, 1:34 AM
astippich accepted this revision.Nov 13 2019, 8:20 PM
astippich added inline comments.
src/ondemandextractor.cpp
3

dito

src/ondemandextractor.h
2

can probably be removed :)

This revision is now accepted and ready to land.Nov 13 2019, 8:20 PM
ngraham accepted this revision.Nov 13 2019, 8:47 PM
This revision was automatically updated to reflect the committed changes.