Remove flawed noLinks handling for originUrls
ClosedPublic

Authored by bruns on Nov 10 2019, 4:21 PM.

Details

Summary

The original use of noLinks was to provide links to "kfileitem#"
targets, i.e. internal links only reachable when file indexing was
enabled (at Nepomuk times).

originUrls on the other hand are web/ftp server URLs, i.e.
independent from any local indexing.

Test Plan
  1. Add a originURL to a file:
$> setfattr -n user.xdg.origin.url -v "http://some.domain/"  test.txt
  1. Make file readonly

With the change, the value label shown for originUrl ("Downloaded
from") stays the same

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Nov 10 2019, 4:21 PM
Restricted Application added a project: Baloo. · View Herald TranscriptNov 10 2019, 4:21 PM
bruns requested review of this revision.Nov 10 2019, 4:21 PM
bruns edited the test plan for this revision. (Show Details)Nov 10 2019, 5:18 PM
ngraham accepted this revision.Nov 10 2019, 11:17 PM
This revision is now accepted and ready to land.Nov 10 2019, 11:17 PM
This revision was automatically updated to reflect the committed changes.