PlacesItemModel: remove redundant set of properties
ClosedPublic

Authored by elvisangelaccio on Nov 9 2019, 9:53 PM.

Details

Summary

The text, icon and url properties are already set in
PlacesItem::setBookmark(), so there is no need to set them here.

The OnlyInApp property is part of the KBookmark object that we are
going to set to the place item, so there is no need to set it here either.

Test Plan
  • Open both dolphin and the Plasma file dialog in some app
  • Edit the text, url, icon and the "Only show when using this application" checkbox in some place item from the file dialog
  • Check whether the place in dolphin keeps getting updated accordingly

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio created this revision.Nov 9 2019, 9:53 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptNov 9 2019, 9:53 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Nov 9 2019, 9:53 PM
elvisangelaccio edited the summary of this revision. (Show Details)Nov 9 2019, 9:56 PM

Remove qDebug line

meven edited the summary of this revision. (Show Details)Nov 10 2019, 6:51 AM
meven accepted this revision.Nov 10 2019, 7:05 AM
This revision is now accepted and ready to land.Nov 10 2019, 7:05 AM
This revision was automatically updated to reflect the committed changes.