New lockscreen
ClosedPublic

Authored by davidedmundson on Aug 22 2016, 1:49 AM.

Details

Summary

New lockscreen

Test Plan

Locked screen and unlocked
Checked caps lock warning
Checked login failed warning
Created multiple new sessions
Switched between sessions

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to New lockscreen.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 22 2016, 1:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Aug 22 2016, 9:34 AM

code looks nice.
you maybe want to add a screenshot, for the final go from vdg

lookandfeel/contents/components/KeyboardLayoutButton.qml
36

does a qmenu work on top the special lockscreen window?

sddm-theme/Login.qml
26

you maybe want to "report the friking thing and put a link" before pushing :)

preview.

lookandfeel/contents/components/KeyboardLayoutButton.qml
36

Turns out it does not.

Which means my options are:

  • come up with an in-window pop-up (IIRC there used to be one back in KDE4 days?)
  • use click to change (so it behaves differently from SDDM.. (I could change SDDM too but the session chooser still needs to be a list really)
    • something else?
mart added a comment.Aug 22 2016, 3:45 PM

feedback just of the screenshot:
what about adding
colorGroup: PlasmaCore.ColorScope.colorGroup
in the userdelegate default avatar as well? (i can do a rr about that as is just partly related if you want)

mart added inline comments.Aug 22 2016, 3:50 PM
lookandfeel/contents/components/KeyboardLayoutButton.qml
36

maybe you are referring to PlasmaComponents.CommonDialog? that should even work in plasma5, tough isn't really used much around.
that thing basically prefers an inline dialog without new windows, but creates a plasmaCore.Dialog if the "fake" dialog doesn't fit into the parent window. it *may* work well enough there.

otherwise, the safest thing here is to do a little fake popup, would just be a rectangle with the list of layouts that gets shown/hidden, that i guess both lockscreen and sddm could share without significant drawbacks

colorGroup: PlasmaCore.ColorScope.colorGroup
in the userdelegate default avatar as well? (i can do a rr about that as is just partly related if you want)

Pushed.

Fixed comment about linking to Qt bug report

Changed keyboard layout button back into click to change
I can make it a custom menu afterwards.

  • Change comment for bug report
  • Restore click to change keyboard layout (for now)
mart accepted this revision.Aug 23 2016, 10:08 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 23 2016, 10:08 AM
This revision was automatically updated to reflect the committed changes.
colomar edited edge metadata.Aug 23 2016, 10:34 AM
colomar added a project: VDG.
colomar added a subscriber: colomar.

Please tag all diffs with UI changes with VDG to make sure we learn about them.