| davidedmundson |
| Plasma |
Album art was patched in 5.16.5 to use PreserveAspectFit, but the code for sourceSize was still applying the width and the height of the container, which do not neccesarily match image dimensions anymore.
Using paintedWidth and paintedHeight should now reflect real image dimensions.
BUG: 413087
FIXED-IN: 5.17.3
I can't reproduce the bug so a user on the bug tracker confirmed this fixes it for them.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 18632 | |
| Build 18650: arc lint + arc unit |
Painted size depends on the aspect ratio of the loaded image. I think it should just be hard-coded to some icon size or grid unit rather than depend on the highly dynamic font rendering (which governs its size effectively as it's the layout's size)
| lookandfeel/contents/lockscreen/MediaControls.qml | ||
|---|---|---|
| 98 | Aha, because of this! paintedWidth still seems wrong though, it'll only be evaluated after it loads the image at which point the sourceSize is too late. | |
Yeah you guys are right. I tested this further and still got some binding loop errors with paintedWidth/Height.
If you have a solution feel free to commandeer the revision to speed things up, this seems like a very important bugfix.
| lookandfeel/contents/lockscreen/MediaControls.qml | ||
|---|---|---|
| 103 | We will display at a fixed height assigned from the layout and we adjust our item width to match the aspect ratio ourselves. Therefore, it only really makes sense to set a height on sourceSize
which is what we want Image loads, we resize our width, but we won't re-evaluate this, so no loop. | |