Differential D25216

Fix translations of $GenericName
ClosedPublic
Actions

Authored by meven on Nov 8 2019, 3:10 PM.

Details

Reviewers
leinir
ngraham
aspotashev
Group Reviewers
Localization
Commits
R304:91f212f983ef: Fix translations of $GenericName
Summary

$GenericName was translated before being passed to KMoreToolsService::formatString,
causing translators to process "$GenericName - ..." in their language, in turn causing formatString not to replace the expected placeholder.

Test Plan

In another language than English:
Open Dolphin
Click on the free space progress bar
Menu appears

Before (with French) :
First entry begins with "$NomGénérique -..."

After:
First entry begins with "Statistiques d'utilisation des disques - ..."

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Nov 8 2019, 3:10 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 8 2019, 3:10 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Nov 8 2019, 3:10 PM
meven added reviewers: leinir, ngraham.Nov 8 2019, 3:10 PM
meven edited the summary of this revision. (Show Details)
meven updated this revision to Diff 69453.Nov 8 2019, 3:11 PM

Amend comment

aspotashev added a subscriber: aspotashev.EditedNov 8 2019, 3:49 PM

I suggest a more flexible approach which allows translators to more around the "$GenericName" part inside their translation and change the " - " separator to anything more appropriate in their language:

i18nc("@action:inmenu %1=\"$GenericName\"", "%1 - current folder", "$GenericName")

(and so on for the other messages)

meven added a comment.Nov 8 2019, 3:52 PM
In D25216#560122, @aspotashev wrote:

I suggest a more flexible approach which allows translators to more around the "$GenericName" part inside their translation and change the " - " separator to anything more appropriate in their language:

i18nc("@action:inmenu %1=\"$GenericName\"", "%1 - current folder", "$GenericName")

(and so on for the other messages)

I like it better will do

aspotashev added a comment.Nov 8 2019, 3:54 PM

In general, string concatenation that you suggested is a big red flag for me as a translator. Concatenation often creates an untranslatable word puzzle.

meven updated this revision to Diff 69461.Nov 8 2019, 3:58 PM

Better translator-friendly implementation

ngraham added a reviewer: Localization.Nov 8 2019, 4:17 PM

LGTM but please wait for approval from a translator too.

ngraham accepted this revision.Nov 8 2019, 4:17 PM
This revision is now accepted and ready to land.Nov 8 2019, 4:17 PM
meven added a comment.Nov 8 2019, 4:31 PM

@aspotashev Is it good for ?

aspotashev accepted this revision.Nov 8 2019, 5:13 PM

LGTM since it fixes the issue.

A next step could be a clearer explaination of what $GenericName will be replaced with. Is it always replaced with Filelight's GenericName from its filelight.desktop file?

meven added a comment.Nov 8 2019, 5:15 PM
In D25216#560212, @aspotashev wrote:

LGTM since it fixes the issue.

A next step could be a clearer explaination of what $GenericName will be replaced with. Is it always replaced with Filelight's GenericName from its filelight.desktop file?

Yes, it uses KMoreToolsService::formatString to replace $GenericName with content from its desktop file.

Closed by commit R304:91f212f983ef: Fix translations of $GenericName (authored by meven). · Explain WhyNov 8 2019, 5:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 69472

View Options

src/kmoretools/kmoretoolsmenufactory.cpp

Loading...