Remove pointless QDBusServiceWatcher
ClosedPublic

Authored by davidedmundson on Fri, Nov 8, 10:19 AM.

Details

Summary

KActivitymanagerd's ksmserver has a QDBusServiceWatcher in order to
recreate a QDBusInterface when the service goes away. There is no need
to do this, a call to a given method to a given service will work
regardless, dispatching to the correct client is all internal to
dbus-daemon.

QDBusAbstractInterface has it's own internal QDBusServiceWatcher anyway
so we don't get any behavioural differences if we check isValid.

This is worth fixing as this class is moved threads and we end up with
newly created children in a mess.

CCBUG: 413940

Test Plan

Compiles. I probably need to run with it for a week or so
and switch activities a bit before merging

Diff Detail

Repository
R161 KActivity Manager Service
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Fri, Nov 8, 10:19 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Nov 8, 10:19 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Fri, Nov 8, 10:19 AM
apol accepted this revision.Fri, Nov 8, 7:32 PM
This revision is now accepted and ready to land.Fri, Nov 8, 7:32 PM
This revision was automatically updated to reflect the committed changes.
broulik added inline comments.
src/service/ksmserver/KSMServer.cpp
45

This is also a perfect candidate for dbus xml?

davidedmundson added inline comments.Sun, Nov 10, 5:51 PM
src/service/ksmserver/KSMServer.cpp
45

It absolutely is. But one change at a time.