Add rpath checking and fixing functionalities on macOS
Needs ReviewPublic

Authored by Inoki on Thu, Nov 7, 11:19 PM.

Details

Reviewers
vonreth
Group Reviewers
Craft
Summary

In the previous versions, rpath in some libraries are still Craft Home or /packaging/xxx, which will lead an error after signing and notarizing app package.

This patch can check the rpath and fix it if one is broken.

Test Plan

Test and fix name == "main", check if all libraries are fixed.

Diff Detail

Repository
R138 Craft
Lint
Lint Skipped
Unit
Unit Tests Skipped
Inoki requested review of this revision.Thu, Nov 7, 11:19 PM
Inoki created this revision.
Inoki added inline comments.
bin/Packager/MacDMGPackager.py
414

I prefer to use re to squash out the rpath, TODO

Inoki added inline comments.Thu, Nov 7, 11:22 PM
bin/Packager/MacDMGPackager.py
258

Maybe we should check the rpath after copying the dependencies.

Otherwise, some libraries which are depending on the rpath, will not be properly found.