There are several logic mistakes in the current code. Compiler warns about them and this patch tries to fix tnem.
- Group Reviewers
Compiles and installs, XMPP part was not tested.
Honestly i'm not convinced touching the iris xmpp code that is a copy of something else is the best of the ideas.
Maybe we can disable the extra warnings for that specific folder?
What do others think?
For the record, this patch fixes problems in s5b.cpp which were earlier fixed upstream:
Last time I tried playing ksirk over jabber network was during upgrade to Qt5. At that time it was defunct and Gael removed the label from the game selection panel. It looks like there's still a way to chose it trough menu.
Has that changed in the meantime?
Almost all compiler warnings are coming from this part of code. I tried to upgrade it to upstream version and test it, but since it was still defunct I couldn't verify the change.
There's also note (jabbergameui.ui): Playing over the Jabber network is an experimental feature in KsirK.
Not sure what's the right way to proceed:
- Drop support/code for playing over Jabber network (remove obsolete iris/xmpp code from ksirk)
- Upgrade to latest upstram (which resolves _all_ compiler warnings in that part of code)
- Keep it like this and fix here and there some compiler warnings
Is it possible to disable warnings for particular folder and does that make sense at all (since the code is still there and compiling)?
This does not make sense for me. These warnings cannot be seen by an ordinary user and they are instructive to see what can be done to enhance the code at the same time.