KCM Colors : port color scheme state management to KConfigXT
ClosedPublic
Actions

Authored by crossi on Nov 7 2019, 5:11 PM.

Details

Reviewers

ervin
mart
bport

Group Reviewers

Plasma

Commits

R119:199bbe20d72c: KCM Colors : port color scheme state management to KConfigXT

Diff Detail

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

crossi created this revision.Nov 7 2019, 5:11 PM

Restricted Application added a project: Plasma. · View Herald TranscriptNov 7 2019, 5:11 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

crossi requested review of this revision.Nov 7 2019, 5:11 PM

Harbormaster completed remote builds in B18572: Diff 69401.Nov 7 2019, 5:11 PM

Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not.

In D25198#559853, @broulik wrote:

Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not.

I assumed the styles were reading them... but maybe that's to be confirmed indeed.

In D25198#559853, @broulik wrote:

Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not.

Thanks for your comment.

I noticed that, since it's a copy from color-scheme to kdeglobals, I thought it was not part of the kcm's state to be managed.

ervin accepted this revision.Nov 12 2019, 10:45 AM

This revision is now accepted and ready to land.Nov 12 2019, 10:45 AM

Closed by commit R119:199bbe20d72c: KCM Colors : port color scheme state management to KConfigXT (authored by crossi). · Explain WhyNov 13 2019, 9:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		kcms/colors/CMakeLists.txt (3 lines)
M		kcms/colors/colors.h (10 lines)
M		kcms/colors/colors.cpp (42 lines)
A	M	kcms/colors/colorssettings.kcfg (13 lines)
A	M	kcms/colors/colorssettings.kcfgc (6 lines)