KCM Colors : port color scheme state management to KConfigXT
ClosedPublic

Authored by crossi on Thu, Nov 7, 5:11 PM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
crossi created this revision.Thu, Nov 7, 5:11 PM
Restricted Application added a project: Plasma. · View Herald TranscriptThu, Nov 7, 5:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
crossi requested review of this revision.Thu, Nov 7, 5:11 PM
broulik added a subscriber: broulik.Fri, Nov 8, 8:57 AM

Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not.

ervin added a comment.Fri, Nov 8, 9:34 AM

Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not.

I assumed the styles were reading them... but maybe that's to be confirmed indeed.

crossi added a comment.Fri, Nov 8, 5:09 PM

Note that the KCM also writes all of the colors into kdeglobals (for whatever reason) - does this also need to be ported? We don't read those colors in the KCM anymore, just write them out when applying, so maybe not.

Thanks for your comment.

I noticed that, since it's a copy from color-scheme to kdeglobals, I thought it was not part of the kcm's state to be managed.

ervin accepted this revision.Tue, Nov 12, 10:45 AM
This revision is now accepted and ready to land.Tue, Nov 12, 10:45 AM
This revision was automatically updated to reflect the committed changes.